this post was submitted on 31 Oct 2024
386 points (98.5% liked)
196
16539 readers
2236 users here now
Be sure to follow the rule before you head out.
Rule: You must post before you leave.
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
oh of course there is
https://www.npmjs.com/package/is-even
(do take a look at the download stats)
And that isn’t even the worst thing about it…
The implementation looks like this:
And yes, is-odd is a dependency that in turn depends on is-number…
Can't you just
return number % 2 === 0Yeah, that's even simpler
but what if
numberisn’t an integer, or even a number at all? This code, and the improved code shared by the other user, could cause major problems under those conditions. Really, what you would want, is to validate thatnumberis actually an integer before performing the modulo, and if it isn’t, you want to throw an exception, because something has gone wrong.That’s exactly what that NPM module does. And this is why it’s not a bad thing to use packages/modules for even very simple tasks, because they help to prevent us from making silly mistakes.
That would already cause an exception when calling the function because it has int number in the parameters
Javascript doesn’t have strongly-typed variables
ah the joys of loosely typed languages
no
ok
yup, which is why I find the download stats truly horrifying
"If it's not an npm package it's impossible"
- JS devs, probably
That's a lot of downloads