I made a terminal based weather application with python. What do you think about the code, is it good enough? I mean is it professional enough and how can I make the same functions with more less code?

Here's the main file (I also added it as url to post): https://raw.githubusercontent.com/TheCitizenOne/openweather/refs/heads/main/openweather.py
Here's the config.json file: https://raw.githubusercontent.com/TheCitizenOne/openweather/refs/heads/main/config.json

you are viewing a single comment's thread
view the rest of the comments

[–] KindaABigDyl@programming.dev 11 points 18 hours ago (2 children)

You appear to be afraid of spaces. Everything is cramped together.

Just bc you don't have to put a space after colons or after equals and commas and whatnot doesn't mean you shouldn't

Don't be afraid of spaces.

They make it easier for you to read your code when you come back later

[–] the_citizen@lemmy.world 1 points 6 hours ago

I revised the code. Added some spaces and comments for better readability. Hope it's better now.

[–] the_citizen@lemmy.world 3 points 18 hours ago (2 children)

Oops, sorry. I will revise the code and place spaces. Thanks for suggestion <3

[–] taaz@biglemmowski.win 7 points 17 hours ago* (last edited 17 hours ago) (1 children)

Usually, you would use a formatter anyway - it's good to know the standard way but for day to day coding I just have a shortcut bound that runs ruff format (you can even have it done automatically on file save).

[–] the_citizen@lemmy.world 1 points 6 hours ago (1 children)

I need to search formatters. Thank you for suggestion.

[–] beeng@discuss.tchncs.de 1 points 1 hour ago

Ruff

[–] Derp@lemmy.ml 5 points 17 hours ago (1 children)

Not the original commenter, but no need to apologise my friend. Nice work. Learning tip from me: give PEP 8 a read and save it for reference somewhere. It's the standard for how to format Python code, and future you will thank you for internalising it early on in your Python journey

[–] the_citizen@lemmy.world 1 points 6 hours ago

Thank you I will read it.