this post was submitted on 28 Sep 2023
320 points (75.6% liked)

Games

32949 readers
977 users here now

Welcome to the largest gaming community on Lemmy! Discussion for all kinds of games. Video games, tabletop games, card games etc.

Weekly Threads:

What Are You Playing?

The Weekly Discussion Topic

Rules:

  1. Submissions have to be related to games

  2. No bigotry or harassment, be civil

  3. No excessive self-promotion

  4. Stay on-topic; no memes, funny videos, giveaways, reposts, or low-effort posts

  5. Mark Spoilers and NSFW

  6. No linking to piracy

More information about the community rules can be found here.

founded 2 years ago
MODERATORS
 

Larion Studios forum stores your passwords in unhashed plaintext. Don't use a password there that you've used anywhere else.

you are viewing a single comment's thread
view the rest of the comments
[–] beefcat@lemmy.world 30 points 1 year ago* (last edited 1 year ago) (2 children)

there is no possible way to handle sensitive data without storing it in memory at some point

it’s where you do all the salting, hashing, and encrypting

emailing out credentials like this after sign up is certainly not best practice, but probably not a huge deal for a video game forum of all things. if you are re-using passwords then you already have a way bigger problem.

[–] JackbyDev@programming.dev 13 points 1 year ago

emailing out credentials like this after sign up is certainly not best practice,

Understatement of the year right here. Everyone in this thread is more interested in dunking on OP for the few wrong statements they make rather than focusing on the fact that a service is emailing their users their password (not an autogenerated "first time" one) in plaintext in an email.

[–] RonSijm@programming.dev 3 points 1 year ago (2 children)

there is no possible way to handle sensitive data without storing it in memory at some point

Since we're nitpicking here - technically you can. They could run hashing client side first, and instead of sending the password in plain-text, you'd send a hashed version

[–] beefcat@lemmy.world 2 points 1 year ago (1 children)

but then you expose your salt to the public

[–] RonSijm@programming.dev 2 points 1 year ago

No, the client side hashing doesn't substitutes anything server side, it just adds an extra step in the client

[–] ilinamorato@lemmy.world 1 points 1 year ago (1 children)

This opens up the possibility of replay attacks in the case of data breaches, though, and those are much more common than http mitm attacks (made even less likely with the proliferation of https).

I'm not entirely sure whether hashing twice (local and server) is wise, having not thought through that entire threat vector. Generally I try to offload auth as much as I can to some sort of oauth provider, and hopefully they'll all switch over to webauthn soon anyway.

[–] RonSijm@programming.dev 1 points 1 year ago (1 children)

I'm not really sure how it opens up replay attacks, since it doesn't really change anything to the default auth. There are already sites that do this.

The only difference is that instead of sending an http request of { username = "MyUsername", Password = "MyPassword" } changes to { username = "MyUsername", Password = HashOf("MyPassword") } - and the HashOf("MyPassword") effectively becomes your password. - So I don't know how that opens up a possibility for replay attack. There's not really any difference between replaying a ClearText auth request vs an pre-hashed auth request. - Because everything else server side stays the same

(Not entirely auth related), but another approach of client side decryption is to handle decryption completely client site - meaning all your data is stored encrypted on the server, and the server sends you an encrypted container with your data that you decrypt client side. That's how Proton(Mail) works in a nutshell

[–] ilinamorato@lemmy.world 1 points 1 year ago (1 children)

I'm not really sure how it opens up replay attacks

Put simply, jt allows an attacker with a leaked database to use the hashed password as a password. In your original comment, it seemed like you were suggesting hashing only before transmission, on the client; but hashing both before and after would indeed patch that particular vulnerability. I don't know if there are potential problems with that strategy or not.

another approach of client side decryption is to handle decryption completely client site

Here's potentially an opportunity for me to learn: how does such a service (like Proton Mail) perform this in a web browser without having access to the data necessary to decrypt all of the data it's sending? Since you can't count on a web browser to have the private key, do you send down an encrypted private key that can only be decrypted with the user's password? Is there some other way to do this that I'm not aware of?

[–] RonSijm@programming.dev 2 points 1 year ago* (last edited 1 year ago) (1 children)

In your original comment, it seemed like you were suggesting hashing only before transmission

Ok, that wasn't what I was suggesting, no. That would effectively make your password hash the password itself - and it would kinda be stored in PlainText on the server, if you skip the client auth and send that value to the server directly through the api or something

how does such a service (like Proton Mail) perform this in a web browser without having access to the data necessary to decrypt all of the data it’s sending? [...] do you send down an encrypted private key that can only be decrypted with the user’s password?

Yes, pretty much. I can't really find a good, detailed explanation from Proton how it exactly works, but LastPass uses the same zero-knowledge encryption approach - which they explained with some diagram here - with a good overview of the client/server separation of it's hashing.

[–] ilinamorato@lemmy.world 1 points 1 year ago

Awesome. Thanks for the links and the info.