133
you are viewing a single comment's thread
view the rest of the comments
[-] anton@lemmy.blahaj.zone 1 points 5 months ago

I looked at the diff, it's around 100 lines of new code and a few hundred lines of comments and tests.
I couldn't have written it, but there are many smarter people that fixed it after they learned of the problem.

What also made it easier to fix is that they (sensibly) chose to error on certain strings that can't be escaped safely.

[-] bizdelnick@lemmy.ml 1 points 5 months ago

It's not a proper fix, there are still cases when correct escaping is impossible and the function simply returns a error. I don"t know if if this possible at all to escape any string or if it is just because of lack of documentation, but anyway i wouldn't call this a thing that is easy to fix.

this post was submitted on 09 Apr 2024
133 points (94.6% liked)

Programming

17028 readers
131 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



founded 1 year ago
MODERATORS