this post was submitted on 13 Sep 2024
31 points (100.0% liked)
News from fediverse
0 readers
1 users here now
founded 10 months ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
Okay, looking at the new embed code more closely, this is...something else.
For comparison, the previous (and on most Mastodon servers, the current) version looked like this.
@stefan@stefanbohacek.online it seems presumptive to my old webdev mind to assume all places that allow embeds will allow external js.
Also, seriously, do you expect me to backdoor my own site??
@stefan@stefanbohacek.online what will happen with previously embedded posts? They'll contain the "old code" with an iframe.
@cybeardjm@masto.ai Any existing embeds will continue to work, including from mastodon.social.
Basically, the plugin will check for the server and post ID from the iframe, and then fetches the status.
Updating the plugin to work with blockquotes should be fairly straightforward, I just need to find the time.
Will keep you posted!
@stefan@stefanbohacek.online It's for the next release I think, 4.3 or so...
Yeah, wouldn't like to redo all my embeds... Yes I have many ;-)
@cybeardjm@masto.ai Yeah, you definitely won't have to do that, the issue is more with wanting to embed posts from any servers running this version of Mastodon.
You will only get the blockquote HTML code, while the plugin looks for iframes, so it just won't do anything.
@cybeardjm@masto.ai Alright, I just went ahead and made the necessary update, it didn't require too much effort.
Let me know once you update the plugin!
@stefan@stefanbohacek.online Old embeds still work ;-)
@cybeardjm@masto.ai Great! Did you also try the new embed, something from mastodon.social?
@stefan@stefanbohacek.online Nope. If I find a post, I'll test.
@cybeardjm@masto.ai Thank you! No rush. It should work and look exactly the same way as with iframes.
@stefan@stefanbohacek.online Anyway, will have to wait for it to work.
My instance is still 4.2.10, so it doesn't seem to work well...
@cybeardjm@masto.ai Oh that's interesting, I am able to replicate this as well.
I added a note to https://github.com/mastodon/mastodon/pull/31766#issuecomment-2351041692.
cc @andypiper@macaw.social
@stefan@stefanbohacek.online @cybeardjm@masto.ai it should still work with the old-style iframe code but with the post URL substituted in (on the Wordpress side)
@andypiper @cybeardjm Right, but this is an issue with the UI, the embed code is missing, see the screenshot I added to the GitHub issue.
@stefan@stefanbohacek.online @cybeardjm@masto.ai 👀 thanks for submitting!
@andypiper@macaw.social @cybeardjm@masto.ai No problem!
@stefan@stefanbohacek.online thx