[-] Atlas_@lemmy.world 6 points 1 day ago

Mostly, they don't

[-] Atlas_@lemmy.world 14 points 6 days ago

The final boss is the most closeted bigot you've ever met. They'll grab some quotes from before they went to therapy for the show and use it as a vehicle for coming out. They will be both.

[-] Atlas_@lemmy.world 2 points 6 days ago

C3, Be7, good chances your opponent will just fold to it here.

[-] Atlas_@lemmy.world 3 points 6 days ago
[-] Atlas_@lemmy.world 37 points 6 days ago

Could also be called homo or phobe

[-] Atlas_@lemmy.world 5 points 1 week ago

I absolutely agree. An even better structure wouldn't have a raw password field on the user object at all.

[-] Atlas_@lemmy.world 19 points 1 week ago* (last edited 1 week ago)

In addition to the excellent points made by steventhedev and koper:

user.password = await hashPassword(user.password);

Just this one line of code alone is wrong.

  1. It's unclear, but quite likely that the type has changed here. Even in a duck typed language this is hard to manage and often leads to bugs.
  2. Even without a type change, you shouldn't reuse an object member like this. Dramatically better to have password and hashed_password so that they never get mixed up. If you don't want the raw password available after this point, zero it out or delete it.
  3. All of these style considerations apply 4x as strongly when it's a piece of code that's important to the security of your service, which obviously hashing passwords is.
[-] Atlas_@lemmy.world 2 points 2 weeks ago

If you want yourself a pillow you can drink, try a hot water bottle

view more: next ›

Atlas_

joined 1 year ago