this post was submitted on 31 Oct 2023
267 points (89.9% liked)

Programmer Humor

19589 readers
2025 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
pylapp@programming.dev
267
thisIsGoingToBeASeriousDebate (programming.dev)
submitted 1 year ago by TadoTheRustacean@programming.dev to c/programmer_humor@programming.dev
40 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] Speiser0@feddit.de 14 points 1 year ago* (last edited 1 year ago) (1 children)

Definitely left. Right one won't be optimized. (And there are ~~so many~~ some mistakes in your inline asm...)

[–] TadoTheRustacean@programming.dev 1 points 1 year ago (1 children)

What mistakes?

[–] Speiser0@feddit.de 6 points 1 year ago (1 children)

Mostly the missing listing of clobbered registers. Other than that it's mostly just that you're doing useless things, like manually putting the stuff into the registers instead of letting the compiler do it, and the useless push and pop. And the loop is obviously not needed and would hurt performance if you do every write like that.

asm!(
"syscall",
in("rax") 1,
in("rdi") 1,
in("rsi") text_ptr,
in("rdx") text_size,

)

("so many" was inappropriate, sorry.)

[–] TadoTheRustacean@programming.dev 1 points 1 year ago (1 children)

I am hopeless at getting the text_ptr simpler than i64::from_str_radix(&format!("{:p}", my_string)[2..], 16).unwrap(); How can i get it the normal way?

[–] Speiser0@feddit.de 2 points 1 year ago

Just use str::as_ptr().

Here's an example (disclaimer: I haven't used inline asm in rust before, expect issues): https://godbolt.org/z/sczYGe96f