171

Lemmy v0.19.4 Release - Image Proxying and Federation improvements (join-lemmy.org)

submitted 3 months ago by hal_5700X@sh.itjust.works to c/fediverse@lemmy.world

22 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[-] ptz@dubvee.org 25 points 3 months ago* (last edited 3 months ago)

In order to improve interoperability with Mastodon and other microblogging platforms, Lemmy now automatically includes a hashtag with new posts.

👎🏻 No way to disable this if I don't want hashtags cluttering up my posts. And worse, it's Lemmy putting words in my mouth / speaking for me.

[Re: Image Proxying] The setting works by rewriting links in new posts, comments and other places when they are inserted in the database. This means the setting has no effect on posts created before the setting was activated. And after disabling the setting, existing images will continue to be proxied. It should also be considered experimental.

What an absolutely stupid way to do image proxying. Why not just dynamically re-write image URLs to use the proxy path before serving it via the API?

That way:

It works with all content posted any time before/after the setting was activated
It lets users decide whether they want to proxy or not
Doesn't break images if the home instance pict-rs is broken (which I've been seeing a lot of lately)

If you think "that's not reliable" or "too hard", I've been doing it successfully exactly that way in Tesseract with it's image proxy/cache for over 8 months (on the front end...in a cave...with a box of scraps).

[-] Max_P@lemmy.max-p.me 20 points 3 months ago

Yeah the image proxy will stay off for me. Mangling user's posts permanently is unacceptable, it's like the whole HTML escaping thing again. You always want to store the original data in its original form that way you have the freedom to tweak the processing at runtime, and if you fuck it up the data isn't permanently fucked up (again, like the 0.18 HTML crap that should never have happened).

[-] Blaze@reddthat.com 7 points 3 months ago

Damn, I had forgotten about that

[-] bevan@lemmy.nz 17 points 3 months ago

The hash tag just adds the community name:

“The hashtag is based on the community name, so posts to /c/lemmy will automatically have the hashtag #lemmy. This makes Lemmy posts much easier to discover.”

Not really putting words in your mouth.

[-] Die4Ever@programming.dev 32 points 3 months ago* (last edited 3 months ago)

for reference, this is what it looks like on Mastodon, the post to !announcements@lemmy.ml it gets the hashtag for announcements

https://mastodon.social/@dessalines@lemmy.ml/112576601493225058

it's not really part of the message text, it's separate

[-] Blaze@reddthat.com 10 points 3 months ago

Thank you for this

[-] taaz@biglemmowski.win 5 points 3 months ago* (last edited 3 months ago)

What a dumb way to do image proxying.

This is about proxying external images, URL rewrite won't work unless the image is also downloaded and hosted by the instance (which seems even worse for many reasons).
Or am I missing something here?

[-] bjoern_tantau@swg-empire.de 9 points 3 months ago

Lemmy will rewrite the image URLs when saving a post.

But instead the URL should be rewritten when loading the post. That way the original URL wouldn't get lost and it would also work for old posts.

[-] ptz@dubvee.org 3 points 3 months ago* (last edited 3 months ago)

You're missing a lot.

I've done exactly what I described in my comment for the last 8 months: it's been a UI feature of Tesseract since last October.

It proxies any image or direct video from any source you haven't blacklisted. If you have the proxy option enabled in your settings, all image URLs are re-written to go through the proxy. If not, then it uses the regular URL directly. It also caches with an admin-defined policy.

[-] taaz@biglemmowski.win 6 points 3 months ago

Oh interesting I will have to look how tessaract does it

[-] ptz@dubvee.org 5 points 3 months ago* (last edited 3 months ago)

And anywhere it renders an image (markdown, posts, avatars/icons, banners, etc), the image source is set via imageProxyURL(url). There's extra optional params for size and format if the image source is served by pict-rs.