926
you are viewing a single comment's thread
view the rest of the comments
[-] NocturnalMorning@lemmy.world 47 points 2 months ago

I always try to review the code anyway. There's no guarantee that what they wrote is doing what you want it to do. Sometimes I find the person was told to do something and didn't realize it actually needs to do Y and not just X, or visa versa.

[-] ScampiLover@lemmy.world 20 points 2 months ago

I like to shoot for the middle ground: skim for key functions and check those, run code locally to see if it does roughly what I think it should do and if it does merge it into dev and see what breaks.

Small PRs get nitpicked to death since they're almost certainly around more important code

[-] derpgon@programming.dev 10 points 2 months ago

Especially when you see a change in code, but not in tests โ˜ ๏ธ

[-] souperk@reddthat.com 2 points 2 months ago

Yes, I always review the code, just avoid nitpicking the hell out of it.

[-] NocturnalMorning@lemmy.world 1 points 2 months ago

Yeah, sorry, totally misread your comment.

this post was submitted on 02 Jul 2024
926 points (98.6% liked)

Programmer Humor

19190 readers
1303 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS